Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Targeting cabability for agent objectives #52

Merged
merged 17 commits into from
Jan 7, 2024

Conversation

thomaswmorris
Copy link
Collaborator

This lets you optimize for a specific value of an objective, instead of just being able to minimize/maximize it. This is useful for e.g. getting a particular beam spot size on demand, or for "color on command" for quantum dot experiments.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mrakitin
Copy link
Member

mrakitin commented Nov 3, 2023

Does this PR share commits with #49?

@mrakitin
Copy link
Member

mrakitin commented Nov 3, 2023

OK, looks like it's only 4 commits ahead of the PR #49 branch:

https://github.com/thomaswmorris/bloptools/compare/objectify...thomaswmorris:bloptools:targeting?expand=1

Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conversion of the DOFs and objectives to Dataclasses looks great! I spotted a few non-critical issues which would be nice to address before merging.

bloptools/bayesian/dofs.py Show resolved Hide resolved
bloptools/bayesian/dofs.py Show resolved Hide resolved
bloptools/bayesian/dofs.py Show resolved Hide resolved
bloptools/bayesian/dofs.py Outdated Show resolved Hide resolved
bloptools/bayesian/objectives.py Show resolved Hide resolved
bloptools/bayesian/transforms.py Show resolved Hide resolved
bloptools/bayesian/transforms.py Show resolved Hide resolved
docs/source/tutorials/himmelblau.ipynb Outdated Show resolved Hide resolved
bloptools/bayesian/devices.py Outdated Show resolved Hide resolved
bloptools/bayesian/dofs.py Outdated Show resolved Hide resolved
@thomaswmorris thomaswmorris merged commit a09f825 into NSLS-II:main Jan 7, 2024
5 checks passed
thomaswmorris added a commit to thomaswmorris/blop that referenced this pull request Jul 15, 2024
Targeting cabability for agent objectives
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants